Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] [Frontend] [Relay] Improve check in flow #517

Merged
merged 11 commits into from
Sep 25, 2024
Merged

[Fix] [Frontend] [Relay] Improve check in flow #517

merged 11 commits into from
Sep 25, 2024

Conversation

Xiawpohr
Copy link
Collaborator

Summary

  • Hide notification after user checks in successfully.
  • Check user reputation every day.
  • Show the reputation history of checking in.

Linked Issue

close #516

@Xiawpohr Xiawpohr changed the title Fix/hide notification after checking in successfully [Fix] [Frontend] [Relay] Improve check in flow Sep 19, 2024
@Xiawpohr Xiawpohr force-pushed the fix/hide-notification-after-checking-in-successfully branch from 969a7cb to 8ff4bd0 Compare September 19, 2024 12:09
kittybest
kittybest reviewed Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, I can get neither the negative reputation nor the positive reputation for both the reporter and respondant, please check

packages/frontend/src/features/reporting/components/DiscardCheckIn/DiscardCheckIn.tsx Outdated Show resolved Hide resolved
packages/frontend/src/features/reporting/hooks/useNotifyCheckIn/useNotifyCheckIn.ts Outdated Show resolved Hide resolved
@Xiawpohr Xiawpohr force-pushed the fix/hide-notification-after-checking-in-successfully branch from 8ff4bd0 to f884504 Compare September 25, 2024 08:16
@vivianjeng vivianjeng force-pushed the fix/hide-notification-after-checking-in-successfully branch 2 times, most recently from 8ff4bd0 to f884504 Compare September 25, 2024 08:25
kittybest
kittybest approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@Xiawpohr Xiawpohr merged commit a5a2e13 into main Sep 25, 2024
5 of 6 checks passed
@Xiawpohr Xiawpohr deleted the fix/hide-notification-after-checking-in-successfully branch September 25, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittybest kittybest kittybest approved these changes

Assignees
No one assigned
Labels
frontend relay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug(frontend): daily check in
2 participants
@Xiawpohr @kittybest